HoustonPutman commented on a change in pull request #560:
URL: https://github.com/apache/solr/pull/560#discussion_r797814806
##########
File path: solr/bin/solr
##########
@@ -2264,6 +2264,7 @@ function start_solr() {
# users who don't care about useful error msgs can override in SOLR_OPTS
with +OmitStackTraceInFastThrow
"${SOLR_HOST_ARG[@]}" "-Duser.timezone=$SOLR_TIMEZONE"
"-XX:-OmitStackTraceInFastThrow" \
"-XX:OnOutOfMemoryError=$SOLR_TIP/bin/oom_solr.sh $SOLR_PORT
$SOLR_LOGS_DIR" \
+ "-Dsolr.packages.local.dir=$SOLR_TIP/contrib" \
Review comment:
So I agree that this likely doesn't need to be customizable. But if we
intend to allow customization, how about we just provide this as a default when
reading in the value? (And also read from both sysProp as well as envVar). That
way there's no need to modify the bin/solr or bin/solr.cmd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
