madrob commented on a change in pull request #583:
URL: https://github.com/apache/solr/pull/583#discussion_r797231013
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -1573,13 +1573,20 @@ public void open() {
*/
@Override
public void close() {
- int count = refCount.decrementAndGet();
- if (count > 0) return; // close is called often, and only actually closes
if nothing is using it.
Review comment:
I kind of like the comment here explaining that close is called often
and I'll be a little sad about losing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
