Caa52 commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r789803776
##########
File path:
solr/contrib/analytics/src/java/org/apache/solr/analytics/AnalyticsDriver.java
##########
@@ -37,28 +37,28 @@
*
* @param manager of the request to drive
* @param searcher the results of the query
- * @param filter that represents the overall query
+ * @param query that represents the overall query
* @param queryRequest used for the search request
* @throws IOException if an error occurs while reading from Solr
*/
- public static void drive(AnalyticsRequestManager manager, SolrIndexSearcher
searcher, Filter filter, SolrQueryRequest queryRequest) throws IOException {
+ public static void drive(AnalyticsRequestManager manager, SolrIndexSearcher
searcher, Query query, SolrQueryRequest queryRequest) throws IOException {
Review comment:
Thanks for pointing this out. I made the changes accordingly.
I made the change to `DocSet` in `AnalyticsDriver` but not in other areas
because the change from `Query` to `DocSet` affects a lot of other APIs further
downstream. I left a _TODO_ comment in `AnalyticsDriver` indicating this. Maybe
we can punt the changes to a future issue?
##########
File path:
solr/contrib/analytics/src/java/org/apache/solr/analytics/facet/AbstractSolrQueryFacet.java
##########
@@ -50,11 +49,11 @@ protected AbstractSolrQueryFacet(String name) {
*
* Each of these executors will be executed after the streaming phase in the
{@link AnalyticsDriver}.
*
- * @param filter the overall filter representing the documents being used
for the analytics request
Review comment:
I made the change to `DocSet` in `AnalyticsDriver` but not in other
areas because the change from `Query` to `DocSet` affects a lot of other APIs
further downstream. I left a _TODO_ comment in `AnalyticsDriver` indicating
this. Maybe we can punt the changes to a future issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
