NazerkeBS commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r788996740



##########
File path: 
solr/core/src/test/org/apache/solr/handler/admin/LoggingHandlerTest.java
##########
@@ -66,27 +70,19 @@ public void testLogLevelHandlerOutput() throws Exception {
                  config.getLoggerConfig(PARENT_LOGGER_NAME));
     assertEquals(Level.DEBUG, 
config.getLoggerConfig(CLASS_LOGGER_NAME).getLevel());
 
-    assertQ("Show Log Levels OK",
-            req(CommonParams.QT,"/admin/logging")
-            
,"//arr[@name='loggers']/lst/str[.='"+CLASS_LOGGER_NAME+"']/../str[@name='level'][.='DEBUG']"
-            
,"//arr[@name='loggers']/lst/str[.='"+PARENT_LOGGER_NAME+"']/../null[@name='level']"
-            );
+    SolrClient client = new EmbeddedSolrServer(h.getCore());
+    ModifiableSolrParams mparams = new ModifiableSolrParams();
+    mparams.set("set", PARENT_LOGGER_NAME + ":TRACE");
+    client.request(new GenericSolrRequest(SolrRequest.METHOD.GET, 
"/admin/info/logging", mparams));
 
-    assertQ("Set a (new) level",

Review comment:
       @dsmiley not sure if we still need to test "Set a (new) level" or "Show 
Log Levels OK" ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to