HoustonPutman opened a new pull request #398: URL: https://github.com/apache/solr-operator/pull/398
Part of #393 As it turns out, `reflect.DeepEquals()` does not actually work correctly for `Quantity` values. This is because, while the actual quantities themselves could be the same, if they have a different `Format`, then `DeepEquals()` will return `false`. So instead we need to use the `Quantity.Equals()` method, which introduces a lot more logic around the seemingly simple check. I've introduced unit tests around this new logic. (and hopefully we can start utilizing more unit tests around `common.go`, which is a behemoth) One problem is that we currently treat an empty resource list and a `nil` resource list differently. We might want to relax this to make sure we are overwriting as little things as possible, when it doesn't really matter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
