magibney edited a comment on pull request #513: URL: https://github.com/apache/solr/pull/513#issuecomment-1016056378
Thanks for the feedback, @epugh! I believe the recent commits have incorporated your suggestions. I also just added an explicit/trivial test expressly for the `[xml]` DocTransformer (in 738b24e6). This test can be run against current `apache-solr/main` to demonstrate that the current behavior of the xml doc transformer is different from the json transformer (and different from what this PR implements/proposes). I'm going to add a comment about this to the jira issue shortly. EDIT: [added comment to Jira issue](https://issues.apache.org/jira/browse/SOLR-9376?focusedCommentId=17478327#comment-17478327) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org