[ 
https://issues.apache.org/jira/browse/SOLR-15337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478711#comment-17478711
 ] 

Jan Høydahl commented on SOLR-15337:
------------------------------------

Ok, I see now that there was a copy-paste bug in the original fix which went 
into 8.9, causing the code *not* to abort startup on for a config using 
"mergeFactor" (since it checked for the non-existent "maxMergeFactor" instead. 
So that was a regression, and 8.11 will still not throw exception for 
"mergeFactor". But now in 9.0 it will. So ideally such behaviour change should 
be called out in CHANGES for the version where the change was done. I can see 
it is not super crucial for this issue in particular, but it is a very 
confusing practice - to re-use a Jira from a released solr version to to 
additional commits. We should not do that.

> Avoid XPath in solrconfig.xml parsing
> -------------------------------------
>
>                 Key: SOLR-15337
>                 URL: https://issues.apache.org/jira/browse/SOLR-15337
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Major
>             Fix For: 8.9
>
>         Attachments: 1433-memtest
>
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> XPath parsing is slow and inefficient



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to