HoustonPutman commented on pull request #479: URL: https://github.com/apache/solr/pull/479#issuecomment-1010097795
> Just to clarify, you're talking about backup format (Response update to use NamedList instead of String) or about aggregated part of the response (switching from array to dictionary)? Or both?. Sorry if I don't understand you correctly. I'm talking about both (make `response` a map, and either remove `Response` or change it's name to something else). Since both are backwards-incompatible changes, I think it would be prudent to do both in 9.0. It seems like you and @cpoerschke are in favor of removing `Response` altogether, just leaving `response`. I think it would be fine to change `Response` -> `message` and leave the information, but if y'all don't think it's useful I won't put up a fight. > I've checked all the sources searching "Response" entry and haven't found any pieces of evidence that value under this key is extracted or parsed somewhere. This means that from the perspective of view of Solr itself it seems that it is safe to replace original Response entry with response entry. That is very good news, thanks for doing that research! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
