[
https://issues.apache.org/jira/browse/SOLR-14290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470666#comment-17470666
]
Gus Heck commented on SOLR-14290:
---------------------------------
I don't think it's a valid release if people don't have a way to reliably test
custom code. How should someone with custom plugins/code run their tests for
that code to see if it breaks in 9.x when the test framework the relied on is
fundamentally broken? Honestly this should have been fixed by the person who
introduced the NPE in the first place, but they got all upset that there wasn't
a unit test for it and refused. I'll take another look this weekend, but it may
require some discussion.
> Fix NPE in SolrTestCaseJ4 breaking external usage for master/9.x
> ----------------------------------------------------------------
>
> Key: SOLR-14290
> URL: https://issues.apache.org/jira/browse/SOLR-14290
> Project: Solr
> Issue Type: Bug
> Components: Tests
> Affects Versions: 9.0
> Environment: Solr Test Framework when run externally such that
> ExternalPaths.SOURCE_HOME is null
> Reporter: Gus Heck
> Assignee: Gus Heck
> Priority: Blocker
> Fix For: 9.0
>
>
> A fix for this was provided on branch_8x in SOLR-14283 but that same fix
> won't work in java 11 due to reflection restrictions that make it impossible
> (AFAIK) to un-final a final variable. We will likely need to employ powermock
> or our own java agent based solution, or redesign the way
> ExternalPaths.determinSourceHome and ExternalPaths.SOURCE_HOME work.
> 8.5 is coming up soon and we can't release with this broken in 8.5 so I'm
> separating the more complicated 9x fix into this ticket.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
