uschindler commented on pull request #502: URL: https://github.com/apache/solr/pull/502#issuecomment-1006966542
> This looks ok to me. An alternative would be to pass options that would open these modules to JavaCompile - see the task's options and fork options - these can be used to always force external compiler and pass module options there? > > https://docs.gradle.org/current/dsl/org.gradle.api.tasks.compile.ForkOptions.html I was thinking about this, too. But the additional complexity wasn't worth to do this. If you run with alternate JVM, I don't think you require errorprone. We can tune this. But then we have to put all those module-opens in 2 different files and I am sure somebody forgets to update them. Also: I am not sure if hooking into javac internal Apis works with possible future JDK versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
