[ 
https://issues.apache.org/jira/browse/SOLR-15873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464940#comment-17464940
 ] 

Christine Poerschke edited comment on SOLR-15873 at 12/24/21, 12:11 PM:
------------------------------------------------------------------------

{quote}... Step 1 in (say) Solr 9.0 ... Step 2 in (say) Solr 9.1 ... probably 
should have shared the outline above first this morning, sorry ...
{quote}
Had idea on how the steps could be combined into one (say) Solr 9.0 release 
whilst preserving backwards compatibility.

illustrative draft pull request: https://github.com/apache/solr/pull/478

The idea is basically to retain existing {{LTR[Interleaving]Rescorer}} APIs  
with {{@deprecated}} annotation for backwards compatibility and with the 
intention to remove them in the next or a subsequent Solr version.


was (Author: cpoerschke):
bq. ... Step 1 in (say) Solr 9.0 ... Step 2 in (say) Solr 9.1 ... probably 
should have shared the outline above first this morning, sorry ...

Had idea on how the steps could be combined into one (say) Solr 9.0 release 
whilst preserving backwards compatibility.

illustrative draft pull requests: to-follow around lunchtime hopefully


> simplify LTR[Interleaving]Rescorer code
> ---------------------------------------
>
>                 Key: SOLR-15873
>                 URL: https://issues.apache.org/jira/browse/SOLR-15873
>             Project: Solr
>          Issue Type: Task
>          Components: contrib - LTR
>            Reporter: Christine Poerschke
>            Priority: Minor
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> On the dev mailing list 
> [https://lists.apache.org/thread/113d1yzty5ryvyt2o9msfytldv41qpgq] thread 
> [~4nn4r] shared about the discovery of the 
> {{org.apache.solr.ltr.LTRRescorer#scoreSingleHit}} code block and how 
> {{hitUpto >= topN}} never arises and so if the piece of code be removed.
> This ticket is about removing (or maybe not) of the code block.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to