epugh commented on a change in pull request #409:
URL: https://github.com/apache/solr/pull/409#discussion_r762428982
##########
File path: solr/core/src/java/org/apache/solr/util/SolrCLI.java
##########
@@ -2845,8 +2845,42 @@ protected void runExample(CommandLine cli, String
exampleName) throws Exception
echo("exampledocs directory not found, skipping indexing step for
the techproducts example");
}
}
+ else if ("films".equals(exampleName) && !alreadyExists) {
+ echo("Adding name and initial_release_data fields to films schema
\"_default\"");
- echo("\nSolr "+exampleName+" example launched successfully. Direct your
Web browser to "+solrUrl+" to visit the Solr Admin UI");
+ HttpSolrClient solrClient = new
HttpSolrClient.Builder(solrUrl).build();
+ try {
+ SolrCLI.postJsonToSolr(solrClient, "/" + collectionName + "/schema",
"{\n" +
Review comment:
Reading through
https://github.com/apache/solr/tree/main/solr/example/films, the whole example
makes a lot of assumptions that you are using _default. If we get rid of
schema autoguessing, then this whole example provides much less value. (Oh,
and despite it being an example of the `useParams` parameter according to ref
guide, I don't actually see it mentioned or used! sigh)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
