[
https://issues.apache.org/jira/browse/SOLR-15209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448900#comment-17448900
]
Ilan Ginzburg edited comment on SOLR-15209 at 11/25/21, 2:03 AM:
-----------------------------------------------------------------
This is vastly more time consuming than I expected. Switching all tests to a
new placement strategy does break many of them. Most obvious tests breaking are
those trying to place more replicas of a shard than there are nodes (the
placement plugin in its current form does not allow that).
Current state of the work is in branch
[SOLR-15209_placementDefault|https://github.com/murblanc/solr/tree/SOLR-15209_placementDefault]
on my github (2 last commits as of now).
I will pause that work for now, I don't have the time.
If somebody wants to pick from where I left, please... and I can help.
I focused on tests failures. I did not test the actual new configuration in
{{solr.xml}} allowing to go back to legacy assign strategy, and I did not test
running a cluster "out of the box" and verifying the plugin affinity assign
strategy works as expected. There are too many test failures anyway at this
stage.
was (Author: murblanc):
This is vastly more time consuming than I expected. Switching all tests to a
new placement strategy does break many of them. Most obvious tests breaking are
those trying to place more replicas of a shard than there are nodes (the
placement plugin in its current form does not allow that).
Current state of the work is in branch
[SOLR-15209_placementDefault|https://github.com/murblanc/solr/tree/SOLR-15209_placementDefault]
on my github.
I will pause that work for now, I don't have the time.
If somebody wants to pick from where I left, please... and I can help.
I focused on tests failures. I did not test the actual new configuration in
{{solr.xml}} allowing to go back to legacy assign strategy, and I did not test
running a cluster "out of the box" and verifying the plugin affinity assign
strategy works as expected. There are too many test failures anyway at this
stage.
> Make the AffinityPlacementFactory the default placement plugin
> --------------------------------------------------------------
>
> Key: SOLR-15209
> URL: https://issues.apache.org/jira/browse/SOLR-15209
> Project: Solr
> Issue Type: Improvement
> Reporter: Andrzej Bialecki
> Assignee: Ilan Ginzburg
> Priority: Blocker
> Fix For: main (9.0)
>
>
> Currently there's a lot of code in {{Assign}} dealing with the fact that we
> still support the old "legacy" replica assignment as well as the new
> plugin-based placement strategies.
> Furthermore, the "legacy" assignment is now the default even though it's
> neither robust nor optimal, except in the very simple and small clusters.
> Also, providing another plugin-based placement as the default impl. runs into
> a small complication - in the absence of any plugin config the code reverts
> to the "legacy".
> In order to promote the adoption of the new plugin-based placements we should
> make the {{AffinityPlacementFactory}} the new default placement strategy,
> selected when the explicit configuration is missing (and then create it as a
> default configuration in {{PlacementPluginFactoryLoader}}).
> I propose to re-package the "legacy" strategy as a {{PlacementPluginFactory}}
> so that it can be configured in the same way as other placement plugins.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
