[ https://issues.apache.org/jira/browse/SOLR-15711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441814#comment-17441814 ]
ASF subversion and git services commented on SOLR-15711: -------------------------------------------------------- Commit 401da355157ef969a80e3fd0be1bd673a7acc51a in solr's branch refs/heads/main from Houston Putman [ https://gitbox.apache.org/repos/asf?p=solr.git;h=401da35 ] SOLR-15711: Fix GCSRepository to follow createDirectory API contract (#373) > Fix GCSRepository to follow BackupRepository.createDirectory API contract > ------------------------------------------------------------------------- > > Key: SOLR-15711 > URL: https://issues.apache.org/jira/browse/SOLR-15711 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - GCS Repository > Reporter: Houston Putman > Assignee: Houston Putman > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Noticed when doing work for SOLR-15702. > The Solr backup commands call {{BackupRepository.createDirectory}} at various > times, while also checking that the same directory exists (via > {{pathExists}}) at different times. The issue here is that during the > distributed Backup commands, (sent to different nodes for each shard), one > node might be at the part of the backup where it is calling > {{createDirectory}} when another node is calling {{pathExists}} for the same > directory. > When following the BackupRepository API Spec correctly, this should not be an > issue because {{createDirectory}} should be a no-op when the directory > already exists. However {{GCSRepository}} does not make this check before > creating the directory. This should be an easy fix. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org