janhoy commented on a change in pull request #402: URL: https://github.com/apache/solr/pull/402#discussion_r745452047
########## File path: solr/core/src/java/org/apache/solr/util/hll/HLL.java ########## @@ -44,10 +44,10 @@ * * This data structure is interoperable with the implementations found at: * <ul> - * <li><a href="https://github.com/aggregateknowledge/postgresql-hll";>postgresql-hll</a>, and</li> + * <li><a href="https://github.com/citusdata/postgresql-hll/blob/master/README.md";>postgresql-hll</a>, and</li> * <li><a href="https://github.com/aggregateknowledge/js-hll";>js-hll</a></li> * </ul> - * when <a href="https://github.com/aggregateknowledge/postgresql-hll/blob/master/STORAGE.markdown";>properly serialized</a>. + * when <a href="https://github.com/metdos/postgresql-hll/blob/master/STORAGE.markdown";>properly serialized</a>. Review comment: It feels a bit strange that we have a July-2015 fork of the hll library in our code base, and then link to live, changing documentation for two different forks of the original library. Better link to the citrusdata repo and a specific version back in time, like https://github.com/citusdata/postgresql-hll/tree/v2.9.0 which is the latest version that seems to have STORAGE.markdown. May not be 100% exact but close enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
