dsmiley commented on a change in pull request #338: URL: https://github.com/apache/solr/pull/338#discussion_r745017095
########## File path: solr/CHANGES.txt ########## @@ -403,6 +403,8 @@ Bug Fixes * SOLR-15653: Fix collection creation race that assumes a local clusterstate when the collection has only just been created. (Mark Miller) +* SOLR-13182: Fix Null Pointer exception for BlockJoinChildQueryParser where parent is null.The fix will apply the parent boolean query only when its not null. (Sayanti Dey) Review comment: ```suggestion * SOLR-13182: {!child} and {!parent} shouldn't throw NPE; return syntax error (Sayanti Dey) ``` ########## File path: solr/CHANGES.txt ########## @@ -403,6 +403,8 @@ Bug Fixes * SOLR-15653: Fix collection creation race that assumes a local clusterstate when the collection has only just been created. (Mark Miller) +* SOLR-13182: Fix Null Pointer exception for BlockJoinChildQueryParser where parent is null.The fix will apply the parent boolean query only when its not null. (Sayanti Dey) Review comment: Notice how I framed this succinctly in terms users can understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org