madrob commented on a change in pull request #389:
URL: https://github.com/apache/solr/pull/389#discussion_r742170960
##########
File path: solr/bin/solr
##########
@@ -1973,7 +1973,7 @@ fi
LOG4J_CONFIG=()
if [ -n "$LOG4J_PROPS" ]; then
- LOG4J_CONFIG+=("-Dlog4j.configurationFile=$LOG4J_PROPS")
+ LOG4J_CONFIG+=("-Dlog4j.configurationFile=$LOG4J_PROPS
-Dlog4j2.is.webapp=false -Dlog4j2.garbagefreeThreadContextMap=true
-Dlog4j2.enableDirectEncoders=true -Dlog4j2.enable.threadlocals=true")
Review comment:
Can you add a comment with a link to some docs or anything else
explaining where these properties come from and how we found them? I'm trying
to search for them and coming up short. Maybe I'll dive into log4j code base
next, although I'd like to avoid that if I can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
