janhoy commented on a change in pull request #372:
URL: https://github.com/apache/solr/pull/372#discussion_r737864469



##########
File path: 
solr/core/src/java/org/apache/solr/handler/admin/ThreadDumpHandler.java
##########
@@ -172,4 +173,9 @@ public String getDescription() {
   public Category getCategory() {
     return Category.ADMIN;
   }
+
+  @Override
+  public Name getPermissionName(AuthorizationContext request) {
+    return Name.CONFIG_READ_PERM;

Review comment:
       Hmm, you list all threads, and for each thread there are some metrics 
like cpuTime, STATE etc. So guess, apart from a user in AdminUI, some metrics 
applications like PromExporter may have interest in this endpoint.. I'll switch 
it to METRICS.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to