dsmiley commented on a change in pull request #329:
URL: https://github.com/apache/solr/pull/329#discussion_r736022743
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
##########
@@ -1265,10 +1265,12 @@ public void processGetUpdates(ResponseBuilder rb)
throws IOException
// TODO: get this from cache instead of rebuilding?
try (UpdateLog.RecentUpdates recentUpdates = ulog.getRecentUpdates()) {
+ Set<Long> updateVersions = new HashSet<>();
Review comment:
Sounds good. We may be oversizing it but ok; it'll be reasonably sized
given we loop over `versions`. We still could use LongSet; why not, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
