j-coll commented on pull request #343: URL: https://github.com/apache/solr-operator/pull/343#issuecomment-949802876
I saw a discrepancy between this "imagePullSecrets" and the one at the zookeeper-operator. I was expecting here a list of objects with "name", but the zookeeper-operator takes a list of strings https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper-operator/values.yaml#L5-L8 Also, the operator is adding those to the service account, instead of the deployment itself: https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper-operator/templates/service_account.yaml#L4-L9 https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper-operator/values.yaml#L23-L24 Which is more in line with your proposal here: https://github.com/apache/solr-operator/pull/339#issuecomment-942424667 @hossman , do you have any preference on where to add the imagePullSecrets? Should we try to be "as close as possible" to the zookeeper-operator? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
