[ 
https://issues.apache.org/jira/browse/SOLR-15629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris M. Hostetter updated SOLR-15629:
--------------------------------------
    Description: 
The original goal of this Jira is now tracked in the We should deprecated & 
remove the following code:
 * {{SolrException.log()}}
 * {{SolrException.ignorePatterns}}
 * {{SolrTestCaseJ4.ignoreException()}}
 * {{SolrTestCaseJ4.unIgnoreException()}}
 * {{SolrTestCaseJ4.resetExceptionIgnores()}}

...and replace with something along the lines of ... (from SOLR-15628) ...
{quote}We should probably re-think the entire existence of 
{{SolrException.log()}} and the API design of {{SolrException.ignorePatterns}} 
– replacing all callers of {{SolrException.log()}} with {{logger.error()}} and 
use a new test-only log4j Filter/Appdener
{quote}
 

  was:
We should deprecated & remove the following code:
 * {{SolrException.log()}}
 * {{SolrException.ignorePatterns}}
 * {{SolrTestCaseJ4.ignoreException()}}
 * {{SolrTestCaseJ4.unIgnoreException()}}
 * {{SolrTestCaseJ4.resetExceptionIgnores()}}

...and replace with something along the lines of ... (from SOLR-15628) ...
{quote}We should probably re-think the entire existence of 
{{SolrException.log()}} and the API design of {{SolrException.ignorePatterns}} 
– replacing all callers of {{SolrException.log()}} with {{logger.error()}} and 
use a new test-only log4j Filter/Appdener
{quote}
 


> Improve the way we "expect" ERROR messages in tests
> ---------------------------------------------------
>
>                 Key: SOLR-15629
>                 URL: https://issues.apache.org/jira/browse/SOLR-15629
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Chris M. Hostetter
>            Assignee: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-15629.patch
>
>
> The original goal of this Jira is now tracked in the We should deprecated & 
> remove the following code:
>  * {{SolrException.log()}}
>  * {{SolrException.ignorePatterns}}
>  * {{SolrTestCaseJ4.ignoreException()}}
>  * {{SolrTestCaseJ4.unIgnoreException()}}
>  * {{SolrTestCaseJ4.resetExceptionIgnores()}}
> ...and replace with something along the lines of ... (from SOLR-15628) ...
> {quote}We should probably re-think the entire existence of 
> {{SolrException.log()}} and the API design of 
> {{SolrException.ignorePatterns}} – replacing all callers of 
> {{SolrException.log()}} with {{logger.error()}} and use a new test-only log4j 
> Filter/Appdener
> {quote}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to