[ https://issues.apache.org/jira/browse/SOLR-15689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17427304#comment-17427304 ]
Christine Poerschke commented on SOLR-15689: -------------------------------------------- * [https://github.com/apache/solr/pull/343] to add test coverage to model the scenarios. * subsequent pull request to follow to fix the logic. > PeerSync inconsistently handles 'delete' highest versions > --------------------------------------------------------- > > Key: SOLR-15689 > URL: https://issues.apache.org/jira/browse/SOLR-15689 > Project: Solr > Issue Type: Bug > Reporter: Christine Poerschke > Assignee: Christine Poerschke > Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Noticed whilst code reading that the > {code} > ... > if (ourLowThreshold > otherHigh && ourHighest >= otherHighest) { > ... > {code} > comparison e.g. > https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.10.0/solr/core/src/java/org/apache/solr/update/PeerSync.java#L792 > presumes that the {{Highest}} values are positive. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org