[
https://issues.apache.org/jira/browse/SOLR-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423023#comment-17423023
]
David Smiley commented on SOLR-15301:
-------------------------------------
The committed solution is a hack that adds complexity. Are we sure the client
simply can't ask for the specific metrics they want? It's an anti-pattern to
ask Solr for all possible metrics (only reasonable in dev / exploration).
An alternative solution that avoids a ThreadLocal is to have a timestamp with
the value and consider the older value to be expired after maybe a second.
> Eliminate repetitive index size calculation for Solr metrics
> ------------------------------------------------------------
>
> Key: SOLR-15301
> URL: https://issues.apache.org/jira/browse/SOLR-15301
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Andras Salamon
> Assignee: Andras Salamon
> Priority: Minor
> Fix For: main (9.0)
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> During metrics calculation Solr asks for core indexSize three times. Twice in
> SolrCore and once in ReplicationHandler. It slows down metrics calculation
> and it is also possible that these three reported values are not exactly the
> same if size changes during calculation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
