[ 
https://issues.apache.org/jira/browse/SOLR-14281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422415#comment-17422415
 ] 

David Smiley commented on SOLR-14281:
-------------------------------------

Just a minor bit of feedback here:
 * NodeConfig.getSharedLibDirectory() I think should have been a List<Path>.  
CoreContainer shouldn't have to wonder what it's format is (comma, etc.); it 
should already be handled by whoever populates NodeConfig.
 * NodeConfig.getSharedLibDirectory could have included "lib" so that this 
"lib" dir isn't some special-case for CoreContainer.

 CoreContainer has tons of responsibilities so let's keep it's job simple where 
we can do so easily.

> Make sharedLib configurable through SysProp and allow multiple paths
> --------------------------------------------------------------------
>
>                 Key: SOLR-14281
>                 URL: https://issues.apache.org/jira/browse/SOLR-14281
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>            Priority: Major
>             Fix For: 8.5
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> solr.xml has support for configuring a {{sharedLib}} location for where to 
> look for shared jar files. But there is currenlty no way to change that 
> location through {{solr.in.sh}} or through SysProp without first editing 
> solr.xml.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to