[ https://issues.apache.org/jira/browse/SOLR-15646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421916#comment-17421916 ]
Mark Robert Miller commented on SOLR-15646: ------------------------------------------- Hmm, I’m looking at this shared keys impact because it’s the second time it’s been brought up as a solution to me and that I’ve felt like it’s a solution implemented by someone not looking at the instigating problem. The main problem with it is that it’s very poor at reducing key generation. Something like 1% of tests even use these keys and that issue only reduces the unnecessary generations a small fraction. It’s a path where you would have to go through and actually make it reduce unnecessary key gens at a large rate in a bunch of cases that are not covered, hope that more cases are not introduced, and still end up generating a key for most of the tests that really have nothing to do with them and do nothing with them. I’ll separate that out from the discussion of whether this is any different than SSL or why Nightly is never considered for slow things unless they are practically abandoned (I think there is value in discussing that), but I think that key sharing issue is again not very impactful to the problem that prompted it. > Add a non secure RSAKeyPair keygen mode for tests. > -------------------------------------------------- > > Key: SOLR-15646 > URL: https://issues.apache.org/jira/browse/SOLR-15646 > Project: Solr > Issue Type: Test > Components: Tests > Reporter: Mark Robert Miller > Assignee: Mark Robert Miller > Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org