[jira] [Commented] (SOLR-15333) Solr-demo in docker uses improper configuration for SpatialRecursivePrefixTreeFieldType

[Steffen Moldenhauer (Jira)]

    [ 
https://issues.apache.org/jira/browse/SOLR-15333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17420701#comment-17420701
 ] 

Steffen Moldenhauer commented on SOLR-15333:
--------------------------------------------

Hi, thanks for the review.

The warnings only appear if the field-type in the schema explicitly configures 
an attribute e.g. "omitNorms" that is hard-coded.

Example from the _default config: 
{code:java}
 <fieldType name="location_rpt" class="solr.SpatialRecursivePrefixTreeFieldType"
 geo="true" distErrPct="0.025" maxDistErr="0.001" distanceUnits="kilometers" 
/>{code}
does not show warnings because no explicitly hard-coded property is specified 
in the field-type.

But if there would be an explicit omitNorms="true" then there will be a warning.

I attached an updated patch that joins the two if-statements and added comments 
about setting the property flags as you recommended. 
I don't know how to unit test the warnings/absence of warnings.

 

> Solr-demo in docker uses improper configuration for 
> SpatialRecursivePrefixTreeFieldType
> ---------------------------------------------------------------------------------------
>
>                 Key: SOLR-15333
>                 URL: https://issues.apache.org/jira/browse/SOLR-15333
>             Project: Solr
>          Issue Type: Task
>    Affects Versions: 8.8.2
>            Reporter: Mike Drob
>            Assignee: David Smiley
>            Priority: Major
>         Attachments: SOLR-15333.patch, SOLR-15333.patch
>
>
> 4/13/2021, 4:54:42 PM
> WARN false
> x:demo
> AbstractSpatialPrefixTreeFieldType
> FieldType SpatialRecursivePrefixTreeFieldType does not allow omitNorms to be 
> specified in schema,&#8203; hardcoded behavior is omitNorms=true
> 4/13/2021, 4:54:42 PM
> WARN false
> x:demo
> AbstractSpatialPrefixTreeFieldType
> FieldType SpatialRecursivePrefixTreeFieldType does not allow 
> omitTermFreqAndPositions to be specified in schema,&#8203; hardcoded behavior 
> is omitTermFreqAndPositions=true
> 4/13/2021, 4:54:42 PM
> When running solr-demo with our docker images, we get a bunch of warnings:
> {noformat}
> FieldType SpatialRecursivePrefixTreeFieldType does not allow omitNorms to be 
> specified in schema,&#8203; hardcoded behavior is omitNorms=true
> FieldType SpatialRecursivePrefixTreeFieldType does not allow 
> omitTermFreqAndPositions to be specified in schema,&#8203; hardcoded behavior 
> is omitTermFreqAndPositions=true
> FieldType SpatialRecursivePrefixTreeFieldType does not allow termOffsets to 
> be specified in schema,&#8203; hardcoded behavior is termOffsets=false
> FieldType SpatialRecursivePrefixTreeFieldType does not allow termPositions to 
> be specified in schema,&#8203; hardcoded behavior is termPositions=false
> FieldType SpatialRecursivePrefixTreeFieldType does not allow omitPositions to 
> be specified in schema,&#8203; hardcoded behavior is omitPositions=true
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org