[
https://issues.apache.org/jira/browse/SOLR-15455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419429#comment-17419429
]
Dawid Weiss commented on SOLR-15455:
------------------------------------
I peeked at the patch, Michael and it seems awkward to me, somehow. I have no
doubt that it works but my gut feeling is that it really should be doable in a
more elegant way... Tweaking dependencies is really where gradle shines -
perhaps it would be possible to just substitute the "locked" lucene version
with a snapshot dependency (and add a local maven repository) at runtime, if a
configuration property is detected?
https://docs.gradle.org/current/userguide/resolution_rules.html#sec:module_replacement
Palantir's version control plugin sometimes clashes with gradle's built-in
mechanisms but it seems like this should be a much nicer (and isolated) hack
than what you suggested.
Yet another (hacky!) alternative that comes to my mind is to use a global
lucene version suffix that is by default empty, you'd then declare dependencies
as:
api "org.apache.lucene:lucene-analysis-kuromoji${rootProject.luceneVersion}"
If you replaced luceneVersion with something else (":9.0.0-SNAPSHOT") in the
main build file, dependencies to Lucene would be fixed, even for Palantir's
plugin.
My personal preference would be to experiment with gradle's mechanism for
altering dependency data but I had little need for it in the past so my
experience is very limited. If you care to try though, it'd be great!
> Facilitate joint Lucene/Solr local development workflow
> -------------------------------------------------------
>
> Key: SOLR-15455
> URL: https://issues.apache.org/jira/browse/SOLR-15455
> Project: Solr
> Issue Type: Improvement
> Components: Build
> Affects Versions: main (9.0)
> Reporter: Michael Gibney
> Priority: Minor
> Attachments: solr-lucene-snapshot-build.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The recommended local development workflow for joint Lucene/Solr development
> post-TLP split requires some changes in order to work properly. The necessary
> changes are few, but there's also some opportunity (with minimal changes) to
> further ease the path for developers. This issue should also encompass
> documentation of the recommended workflow.
> Continued from a solr-dev [mailing list
> thread|https://mail-archives.apache.org/mod_mbox/solr-dev/202106.mbox/%3ccajrvfdryqu+hbzdiimaxtsab2e4nyeais-3sfzw6v3zv3gy...@mail.gmail.com%3e].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
