vladiceanu commented on a change in pull request #324:
URL: https://github.com/apache/solr-operator/pull/324#discussion_r715067459
##########
File path: controllers/util/solr_util.go
##########
@@ -327,6 +328,13 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud,
solrCloudStatus *solr.SolrCl
}
}
+ // Default preStop hook
+ preStop := &corev1.Handler{
Review comment:
Make sense. I've cleaned up the tests of `preStop` hook that were based
on ENV variable `SOLR_PORT` because we're passing different Lifecycle values
and that won't work; in any case, we already have a test for ENV variables.
Also, I have added the Lifecycle tests for SolrCloud and PromExporter
STS/Deployment.
Please have a look and let me know if I miss anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
