gerlowskija commented on pull request #302: URL: https://github.com/apache/solr-operator/pull/302#issuecomment-920856983
Alright, quick update on my progress here. Since I last posted, I've - addressed all of Houston's requests (except two where I asked for clarification on what he wanted done) - fixed a bug mentioned earlier around updating backup status when persistence was skipped. - added some unit tests - added examples (under `examples/`) and re-wrote the backup docs (in `docs/solr-backup/README.md`) - done misc cleanup (e.g. removing personal debug logging, etc.) That's everything I had planned to do here, unless @HoustonPutman has other feedback or gets a chance to see my responses from his earlier review. But otherwise I think this is ready to go? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org