HoustonPutman opened a new pull request #271:
URL: https://github.com/apache/solr/pull/271


   https://issues.apache.org/jira/browse/SOLR-15599
   
   So far the checklist:
   
   - [ ] The tests run and pass, with similar times (Had to change to use the 
http client in the tests, because https caused a large slowdown when uploading 
files to s3mock)
   - [ ] Documentation updates, such as the new proxy config param and 
system/env properties for auth.
   - [ ] I think the dependencies are good, but I'd love a check around that.
   
   One thing I couldn't find a similar setting for in the v2 client was: (not 
sure if this is actually an issue or not)
   
   ```java
   new ClientConfiguration().withProtocol(Protocol.HTTPS);
   ```
   
   It also looks like the multi-part-upload in v2 doesn't have an idea of a 
"last part", but the whole process is a little more controlled anyways, and the 
tests pass, so it should be fine?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to