epugh commented on pull request #264: URL: https://github.com/apache/solr/pull/264#issuecomment-903249838
THanks for the comments @dsmiley I will go through and make edits. I *think* when I am done with this change, I'd like to revisit the ManagedSchema codebase and see if there was some way to refactor it to be cleaner. It just feels very convoluted, and it seems conceptually like it shouldn't be so complex! SOmething for another JIRA, I am trying hard NOT to start pulling on the refactoring thread in this JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org