HoustonPutman commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690739265
########## File path: controllers/util/solr_util.go ########## @@ -601,6 +552,11 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *solr.SolrCl } } + // Enrich the StatefulSet config to enable TLS on Solr pods if needed + if tls != nil { + tls.enableTLSOnSolrCloudStatefulSet(stateful) Review comment: Yeah this is great. Hopefully we can abstract out other parts of this awful method and make it nice and clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org