madrob commented on a change in pull request #260: URL: https://github.com/apache/solr/pull/260#discussion_r688010778
########## File path: solr/core/src/java/org/apache/solr/pkg/PackageLoader.java ########## @@ -360,6 +360,7 @@ public InputStream openResource(String resource) { } } + @SuppressWarnings("CompareToZero") // TODO either document why or fix this Review comment: @noblepaul do you recall why you did `v.compareTo(lessThan) < 1` down below? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org