dsmiley commented on a change in pull request #214:
URL: https://github.com/apache/solr/pull/214#discussion_r672779442
##########
File path: solr/test-framework/src/java/org/apache/solr/util/RandomizeSSL.java
##########
@@ -104,10 +105,10 @@ public SSLRandomizer(double ssl, double clientAuth,
String debug) {
public SSLTestConfig createSSLTestConfig() {
// even if we know SSL is disabled, always consume the same amount of
randomness
// that way all other test behavior should be consistent even if a user
adds/removes @SuppressSSL
-
- final boolean useSSL = TestUtil.nextInt(LuceneTestCase.random(), 0, 999)
<
+ Random random = new Random();
Review comment:
@dweiss any thoughts on the above?
In general, it'd be nice to have code that uses a consistent random number
and be compatible with RandomizedTesting yet not actually depend on
RnadomizedRunner (e.g. because the code _sometimes_ runs without RR -- e.g.
benchmark).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
