gerlowskija commented on a change in pull request #218:
URL: https://github.com/apache/solr/pull/218#discussion_r669902144



##########
File path: 
solr/solrj/src/java/org/apache/solr/common/params/CommonAdminParams.java
##########
@@ -27,6 +27,8 @@
   String IN_PLACE_MOVE = "inPlaceMove";
   /** Method to use for shard splitting. */
   String SPLIT_METHOD = "splitMethod";
+  /** Key to use during shard splitting */
+  String SPLIT_KEY = "split.key";

Review comment:
       That'd be my preference, yep.  This constant only uses dot-delimiting 
since that's what the v1 API used up to this point.  And it's only used for the 
v1 API, so there's the convention doesn't spill into v2-land.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to