madrob commented on a change in pull request #207:
URL: https://github.com/apache/solr/pull/207#discussion_r668140261
##########
File path:
solr/core/src/java/org/apache/solr/update/processor/MaxFieldValueUpdateProcessorFactory.java
##########
@@ -55,20 +55,19 @@
public final class MaxFieldValueUpdateProcessorFactory extends
FieldValueSubsetUpdateProcessorFactory {
@Override
- @SuppressWarnings({"unchecked"})
- public Collection<Object>
pickSubset(@SuppressWarnings({"rawtypes"})Collection values) {
- @SuppressWarnings({"rawtypes"})
- Collection result = values;
+ public <T> Collection<T> pickSubset(Collection<T> values) {
try {
+ // TODO: Verify this
// NOTE: the extra cast to Object is needed to prevent compile
// errors on Eclipse Compiler (ecj) used for javadoc lint
Review comment:
I'm not actually sure how to verify this, does ecj run as part of one of
our grade targets?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
