madrob commented on a change in pull request #196:
URL: https://github.com/apache/solr/pull/196#discussion_r660134018
##########
File path: solr/core/src/test/org/apache/solr/util/SolrPluginUtilsTest.java
##########
@@ -248,7 +248,7 @@ public void testDisjunctionMaxQueryParser() throws
Exception {
}
- private static int countItems(@SuppressWarnings({"rawtypes"})Iterator i) {
+ private static int countItems(Iterator<?> i) {
Review comment:
I intentionally went with the more general approach here, because I
wasn't sure if it would be useful in other place or not. While doing these
massive refactorings, I have seen a lot of duplicate or near duplicate code so
I'm starting to get a little more sensitive to it.
##########
File path: solr/core/src/test/org/apache/solr/TestRandomDVFaceting.java
##########
@@ -125,7 +125,7 @@ void deleteSomeDocs() {
int percent = rand.nextInt(100);
if (model == null) return;
ArrayList<String> ids = new ArrayList<>(model.size());
- for (@SuppressWarnings({"rawtypes"})Comparable id : model.keySet()) {
+ for (Comparable<?> id : model.keySet()) {
Review comment:
Yes, all the Comparable stuff in Facets and Groups and Fields is going
to need to be it's own issue. I'm not entirely certain how to deal with it at
this point, and some of it depends on what Lucene does with their APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
