tomglk commented on a change in pull request #166:
URL: https://github.com/apache/solr/pull/166#discussion_r655924437
##########
File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRScoringQuery.java
##########
@@ -223,6 +223,7 @@ public ModelWeight createWeight(IndexSearcher searcher,
ScoreMode scoreMode, flo
else{
createWeightsParallel(searcher, scoreMode.needsScores(), featureWeights,
features);
}
+ // TODO: potential prefetchFields computation site?
Review comment:
Hi @cpoerschke ,
from the approaches that we discussed until now, I like this one best.
I committed your implementation in 7ac6e35.
(Also, I did a few small changes to fix the tests and some renaming because
the terms `frozen` and `freeze` made it a bit hard to understand.)
##########
File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRScoringQuery.java
##########
@@ -223,6 +223,7 @@ public ModelWeight createWeight(IndexSearcher searcher,
ScoreMode scoreMode, flo
else{
createWeightsParallel(searcher, scoreMode.needsScores(), featureWeights,
features);
}
+ // TODO: potential prefetchFields computation site?
Review comment:
Hi @cpoerschke ,
from the approaches that we discussed until now, I like this one best.
I committed your implementation in 7ac6e35.
(Also, I did a few small changes to fix the tests and some renaming because
the terms `frozen` and `freeze` made it a bit hard to understand.)
Tests for that are missing. Yesterday evening felt a bit too late to start
with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
