dsmiley commented on a change in pull request #175:
URL: https://github.com/apache/solr/pull/175#discussion_r655840132



##########
File path: solr/core/src/java/org/apache/solr/search/HashQParserPlugin.java
##########
@@ -114,7 +116,12 @@ public LongValues getValues(LeafReaderContext ctx, 
DoubleValues scores) throws I
             @Override
             public long longValue() throws IOException {
               //TODO: maybe cache hashCode if same ord as prev doc to save 
lookupOrd?
-              return atDoc ? values.lookupOrd(values.ordValue()).hashCode() : 
0;
+              return atDoc ? hashCode(values.lookupOrd(values.ordValue())) : 0;
+            }
+
+            private long hashCode(BytesRef bytesRef) {

Review comment:
       anonymous inner classes can't have static methods.  But I'll change to 
int from long




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to