bruno-roustant commented on a change in pull request #147:
URL: https://github.com/apache/solr/pull/147#discussion_r639587170
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -2264,13 +2264,13 @@ public void run() {
// any cores to close.
}
}
- for (SolrCore removeMe = solrCores.getCoreToClose();
- removeMe != null && !container.isShutDown();
Review comment:
There was a bug here: when the CoreContainer was shutting down it was
possible to get the core to close (and remove it from the pendingClose list)
and then simply skip the core by exiting this method without closing it. It
resulted in unreleased Core as well as other related objects (Directory, etc).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
