HoustonPutman commented on a change in pull request #133:
URL: https://github.com/apache/solr/pull/133#discussion_r635528678
##########
File path: solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java
##########
@@ -87,7 +88,20 @@ public void startReplication(boolean switchTransactionLog) {
NamedList<Object> followerConfig = new NamedList<>();
followerConfig.add("fetchFromLeader", Boolean.TRUE);
-
followerConfig.add(ReplicationHandler.SKIP_COMMIT_ON_LEADER_VERSION_ZERO,
switchTransactionLog);
+
+ // don't commit on leader version zero for PULL replicas as PULL should
only get its index state from leader
+ boolean skipCommitOnLeaderVersionZero = switchTransactionLog;
+ final CloudDescriptor cloudDescriptor =
core.getCoreDescriptor().getCloudDescriptor();
+ if (cloudDescriptor != null) {
Review comment:
maybe only check this if !skipCommitOnLeaderVersionZero
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
