[
https://issues.apache.org/jira/browse/SOLR-14245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346758#comment-17346758
]
Andrzej Bialecki edited comment on SOLR-14245 at 5/18/21, 9:58 AM:
-------------------------------------------------------------------
I strongly disagree - let's not revert, instead fix the bug that caused the
invalid state! {{Replica}} is a critical piece of information, if it's invalid
then something seriously wrong already happened.
That's the whole point of validation, to quickly catch errors that can cause
long-term subtle corruption. If the validation logic is somehow faulty and
there's an edge-case that it should accept, then we can fix it - but I'm
against removing it.
was (Author: ab):
I strongly disagree - let's not revert, instead fix the bug that caused the
invalid state! {{Replica}} is a critical piece of information, if it's invalid
then something seriously wrong already happened.
That's the whole point of validation, to quickly catch errors that can cause
long-term subtle corruption.
> Validate Replica / ReplicaInfo on creation
> ------------------------------------------
>
> Key: SOLR-14245
> URL: https://issues.apache.org/jira/browse/SOLR-14245
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Minor
> Fix For: 8.5
>
>
> Replica / ReplicaInfo should be immutable and their fields should be
> validated on creation.
> Some users reported that very rarely during a failed collection CREATE or
> DELETE, or when the Overseer task queue becomes corrupted, Solr may write to
> ZK incomplete replica infos (eg. node_name = null).
> This problem is difficult to reproduce but we should add safeguards anyway to
> prevent writing such corrupted replica info to ZK.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
