janhoy commented on a change in pull request #116:
URL: https://github.com/apache/solr/pull/116#discussion_r627515778



##########
File path: solr/contrib/prometheus-exporter/conf/solr-exporter-config.xml
##########
@@ -1053,6 +1053,51 @@
           </str>
         </arr>
       </lst>
+      <lst name="request">
+        <lst name="query">
+          <str name="path">/admin/zookeeper/status</str>
+        </lst>
+        <arr name="jsonQueries">
+          <str>
+            .zkStatus.ensembleSize as $value |
+            .zkStatus.mode as $mode |
+            {
+            name         : "solr_zookeeper_ensemble_size",
+            type         : "GAUGE",
+            help         : "See following URL: 
https://solr.apache.org/guide/cloud-screens.html#zk-status-view";,
+            label_names  : [],
+            label_values : [],
+            value        : $value
+            }
+          </str>
+          <str>
+            .zkStatus.details[] as $object |
+            $object.host as $host |
+            $object.ok as $ok |
+            (if $object.clientPort != null and $ok then 1.0 else 0.0 end) as 
$value |

Review comment:
       We require both an "imok" response to the "ruok" 4lw, as well as the 
presense of clientPort, to work around the bug fixed in SOLR-15383 (zk node 
responds "imok" even if it is not connected to ensemble)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to