janhoy edited a comment on pull request #105: URL: https://github.com/apache/solr/pull/105#issuecomment-829590931
Thanks for the review @madrob . The issue occurs in https://github.com/apache/solr/blob/main/solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java#L1095 when SolrJ tries to identiy a path as admin or not. I wonder why we compare with a hard-coded set of absolute paths instead of doing pattern matching, e.g. `request.getPath().startsWith("/admin/")`? The `/solr/admin/*` path is reserved for admin, there cannot be a core/collection named "admin", can there? @madrob andy thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
