[ https://issues.apache.org/jira/browse/SOLR-15067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330914#comment-17330914 ]
Bence Szabó commented on SOLR-15067: ------------------------------------ I have created a pull request with the implementation duplicated from ChildDocTransformerFactory. Can you check it out and comment your opinion when you have time? Thanks. > Child doc transformer should use the perSegFilter cache > ------------------------------------------------------- > > Key: SOLR-15067 > URL: https://issues.apache.org/jira/browse/SOLR-15067 > Project: Solr > Issue Type: Improvement > Reporter: David Smiley > Priority: Major > Labels: newdev > Time Spent: 10m > Remaining Estimate: 0h > > The ChildDocTransformerFactory creates a QueryBitSetProducer every time. > These are heavy to compute; they should be cached. > BlockJoinParentQParserPlugin does this correctly, using the "perSegFilter" > named Solr cache. They should both do the same. To avoid duplication of > logic, consider creating a new class named something like > PerSegFilterCacheManager, or maybe manage directly on SolrIndexSearcher > (alas; SIS is huge). -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org