gerlowskija opened a new pull request #81: URL: https://github.com/apache/solr/pull/81
This commit converts MODIFYCOLLECTION, the first of the /v2/c/<coll> APIs. None of the other APIs have been touched (yet), just for lack of time. This leaves RELOAD, MOVEREPLICA, MIGRATEDOCS, BALANCESHARDUNIQUE, REBALANCELEADERS, ADDREPLICAPROPERTY, DELETEREPLICAPROPERTY, and SETCOLLECTIONPROPERTY. When all these are added, tests are still needed and the apispec file containing them all needs deleted. # Description Solr has two mechanisms for implementing v2 APIs: an apispec (i.e. JSON file) based approach, and a newer approach that uses annotated POJOs. A consensus has emerged across many JIRAs that the latter approach is preferable going forward, since it reduces duplication and inches the code closer to strongly-typed APIs. But moving existing APIs over to this new mechanism is a big task. # Solution This PR aims to migrated Solr's `/v2/collections/<collection>` APIs to the new preferred mechanism. # Tests See the (as yet unimplemented) tests in `V2SpecificCollectionAPIMappingTest` # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
