[ https://issues.apache.org/jira/browse/SOLR-15252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322359#comment-17322359 ]
Jan Høydahl commented on SOLR-15252: ------------------------------------ {quote}I would be so bold as to set the logging threshold even lower, maybe 10k or 50k. {quote} Sure, we can do that. I think I'll lower it to 10k and at the same time mute the warn for 1h istead of 1m, since the warn will be much more frequent with such a threshold. Do we need a system property to mute this log permanently? Alternatively use a separate logging class which can then be filtered in log4j2.xml? > Solr should log WARN log when a query requests huge rows number > --------------------------------------------------------------- > > Key: SOLR-15252 > URL: https://issues.apache.org/jira/browse/SOLR-15252 > Project: Solr > Issue Type: Improvement > Components: query > Reporter: Jan Høydahl > Assignee: Jan Høydahl > Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > We have all seen it - clients that use Integer.MAX_VALUE or 10000000 as rows > parameter, to just make sure they get all possible results. And this of > course leads to high GC pauses since Lucene allocates an array up front to > hold results. > Solr should either log WARN when it encounters a value above a certain > threshold, such as 100k (then you should use cursormark instead). Or it > should simply respond with 400 error and have a system property or query > parameter folks can use to override if they know what they are doing. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org