janhoy commented on a change in pull request #78:
URL: https://github.com/apache/solr/pull/78#discussion_r614272064
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java
##########
@@ -236,6 +240,21 @@ public void prepare(ResponseBuilder rb) throws IOException
if (rb.getSortSpec().getOffset() < 0) {
throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, "'start'
parameter cannot be negative");
}
+ if(rb.getSortSpec().getCount() > ROWS_WARN_THRESHOLD &&
shouldLogPeriodically("rowsWarn", 60)) {
+ log.warn("Very high 'rows' parameter detected. This may lead to
performance- and memory problems. " +
+ "Consider pagination, see
https://solr.apache.org/guide/pagination-of-results.html. " +
+ "This warning will mute for 60s.");
Review comment:
Should the default mute be 3600s instead? 24 WARN logs per day should be
enough to draw attention to this issue in most systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
