[ 
https://issues.apache.org/jira/browse/SOLR-15274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306710#comment-17306710
 ] 

David Smiley commented on SOLR-15274:
-------------------------------------

Thanks for looking Hoss!

In the PR, the config file is *not* reloaded if it didn't change; the file 
modification date is used to detect this (cheap).  A core reload isn't 
necessary to pick up changes; you can do a soft commit assuming your data has 
changed as well (else a commit will no-op?).

I agree that in SolrCloud, we could add a feature to "watch" for changes.  If 
such a thing gets added, I'd prefer it be done in a general way in either 
ConfigSetService or the SolrResourceLoader it creates so that consumers (QEC) 
can be kept simple and free of implementation details that are ConfigSetService 
specific.  BTW I'm working with [~nazerke] on a major refactoring of 
ConfigSetService in SOLR-15258 right now that ought to be merged this week.

I'd rather not add code to QEC to look in old places.  If someone doesn't read 
the release notes, they will find that QEC throws an error that it can't find 
the config after which they'll find out, perhaps after reading the release 
notes / ref guide _then_.

> QueryElevationComponent: auto-load file changes; remove data dir support
> ------------------------------------------------------------------------
>
>                 Key: SOLR-15274
>                 URL: https://issues.apache.org/jira/browse/SOLR-15274
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SearchComponents - other
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> QueryElevationComponent can detect changes to its elevate.xml file and load 
> it following a commit (new searcher).  But this only works when the file is 
> in the "data" dir, which is weird.  I wish to +remove+ support for the data 
> dir and add this auto-loading mechanism to standard conf/configSet location.  
> Additionally, I wish to +remove+ QEC's support of the elevate.xml file to be 
> "versioned" -- e.g. elevate.xml.001, elevate.xml.002.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to