Copilot commented on code in PR #2687:
URL: https://github.com/apache/sedona/pull/2687#discussion_r2886769976
##########
docs/api/snowflake/vector-data/Geometry-Accessors/ST_GeometryType.md:
##########
@@ -21,6 +21,8 @@
Introduction: Returns the type of the geometry as a string. EG:
'ST_Linestring', 'ST_Polygon' etc.
+
Review Comment:
The Introduction uses the example string `ST_Linestring`, but
`ST_GeometryType` returns `ST_` + the JTS geometry type (e.g.,
`ST_LineString`). Since this page now includes the visual, the incorrect casing
stands out more—please update the Introduction examples to match the actual
output.
##########
docs/api/flink/Geometry-Accessors/ST_GeometryType.md:
##########
@@ -21,6 +21,8 @@
Introduction: Returns the type of the geometry as a string. EG:
'ST_Linestring', 'ST_Polygon' etc.
+
+
Review Comment:
The Introduction uses the example string `ST_Linestring`, but
`ST_GeometryType` delegates to
`org.apache.sedona.common.Functions.geometryType`, which returns `ST_` + the
JTS geometry type (e.g., `ST_LineString`). Also, the example output here shows
`ST_LINESTRING`, which appears inconsistent with `geometryType()`’s actual
return value. Please update the Introduction/example output casing to match the
function’s real output.
##########
docs/api/sql/Geometry-Accessors/ST_GeometryType.md:
##########
@@ -21,6 +21,8 @@
Introduction: Returns the type of the geometry as a string. EG:
'ST_Linestring', 'ST_Polygon' etc.
+
Review Comment:
The Introduction uses the example string `ST_Linestring`, but the function
returns `ST_` + JTS geometry type (e.g., `ST_LineString`). This mismatch is
already visible in the example output below and in the new visual. Please
adjust the Introduction examples to use the correct casing (e.g.,
`ST_LineString`).
##########
docs/api/sql/Geometry-Accessors/ST_IsPolygonCW.md:
##########
@@ -21,6 +21,8 @@
Introduction: Returns true if all polygonal components in the input geometry
have their exterior rings oriented counter-clockwise and interior rings
oriented clockwise.
+
Review Comment:
The introduction describes CCW exterior / CW interior ring orientation, but
`ST_IsPolygonCW` actually returns true when the exterior ring is clockwise and
interior ring(s) are counter-clockwise (see
`common/src/main/java/org/apache/sedona/common/Functions.java` Javadoc for
`isPolygonCW`). Please update the Introduction text to match the actual
semantics; otherwise this new visual ("CW → true") conflicts with the doc.
##########
docs/api/flink/Geometry-Accessors/ST_IsPolygonCW.md:
##########
@@ -21,6 +21,8 @@
Introduction: Returns true if all polygonal components in the input geometry
have their exterior rings oriented counter-clockwise and interior rings
oriented clockwise.
Review Comment:
The introduction currently describes CCW exterior / CW interior ring
orientation, but `ST_IsPolygonCW` returns true when the exterior ring is
clockwise and interior ring(s) are counter-clockwise (per
`org.apache.sedona.common.Functions.isPolygonCW`). Please update the
Introduction so it matches the actual semantics; otherwise the new visual ("CW
→ true") contradicts the text.
```suggestion
Introduction: Returns true if all polygonal components in the input geometry
have their exterior rings oriented clockwise and interior rings oriented
counter-clockwise.
```
##########
docs/api/snowflake/vector-data/Geometry-Accessors/ST_IsPolygonCW.md:
##########
@@ -21,6 +21,8 @@
Introduction: Returns true if all polygonal components in the input geometry
have their exterior rings oriented counter-clockwise and interior rings
oriented clockwise.
+
Review Comment:
The introduction describes CCW exterior / CW interior ring orientation, but
`ST_IsPolygonCW` returns true when the exterior ring is clockwise and interior
ring(s) are counter-clockwise (per
`org.apache.sedona.common.Functions.isPolygonCW`). Please update the
Introduction text so it matches the function behavior; otherwise it conflicts
with the new visual.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
